Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixed path level server and description requirement in spec file #247

Merged
merged 3 commits into from
Apr 30, 2024
Merged

chore: fixed path level server and description requirement in spec file #247

merged 3 commits into from
Apr 30, 2024

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Two major issues:

  1. Servers - CLI expects servers to be specified at the path level currently like this, however it should support servers defined at top level if it is common for all the path like this
  2. Description - CLI expects a description at path level. If no description is given, it should set be set to blank

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tiwarishubham635 tiwarishubham635 merged commit fe3db94 into main Apr 30, 2024
9 checks passed
@tiwarishubham635 tiwarishubham635 deleted the fix_path_level branch April 30, 2024 05:38
@tiwarishubham635 tiwarishubham635 mentioned this pull request May 24, 2024
Merged
8 tasks
twilio-dx pushed a commit that referenced this pull request May 24, 2024
@semantic-release-bot
chore(release): set package.json to 7.24.0 [skip ci]
f254b6f 
## [7.24.0](7.23.4...7.24.0) (2024-05-24)

### Library - Chores

* fixed path level server and description requirement in spec file ([#247](#247)) ([fe3db94](fe3db94))
* fixing kebab-case error ([#248](#248)) ([31b1e31](31b1e31))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbansla sbansla sbansla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiwarishubham635 @sbansla